Source/bindings/templates/conversions.cpp - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/templates/conversions.cpp

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: drop throw_expression, re-add set_expression Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 {% macro v8_value_to_local_cpp_value(thing) %}

	2 {# This indirection is just to avoid spurious white-space lines. #}

	3 {{generate_v8_value_to_local_cpp_value(thing) \| trim}}

	4 {%- endmacro %}

	5

	6

	7 {% macro generate_v8_value_to_local_cpp_value(thing) %}

	8 {% set item = thing.v8_value_to_local_cpp_value or thing %}
	bashi 2015/02/25 04:44:35 Just a comment: I guess you do this to avoid writi Just a comment: I guess you do this to avoid writing \|thing.v8_value_to_local_cpp_value\| in call sites, but it may make readers difficult to understand what argument type this macro takes.
	9 {% if item.error_message %}

	10 /* {{item.error_message}} */

	11 {% else %}

	12 {% if item.declare_variable %}

	13 {% if item.assign_expression %}

	14 {{item.cpp_type}} {{item.cpp_name}} = {{item.assign_expression}};

	15 {% else %}

	16 {{item.cpp_type}} {{item.cpp_name}};

	17 {% endif %}

	18 {% else %}{# item.declare_variable #}

	19 {% if item.assign_expression %}

	20 {{item.cpp_name}} = {{item.assign_expression}};

	21 {% endif %}

	22 {% endif %}{# item.declare_variable #}

	23 {% if item.set_expression %}

	24 {{item.set_expression}};

	25 {% endif %}

	26 {% if item.check_expression %}

	27 if ({{item.check_expression}})

	28 return{% if item.return_expression %} {{item.return_expression}}{% endif %};

	29 {% endif %}{# item.check_expression #}

	30 {% endif %}{# item.error_message #}

	31 {% endmacro %}

	32

	33
	bashi 2015/02/25 04:44:35 nit: remove the second empty line? nit: remove the second empty line? Jens Widell 2015/02/25 07:49:43 Done. Show quoted text On 2015/02/25 04:44:35, bashi1 wrote: > nit: remove the second empty line? Done.
OLD	NEW