Source/bindings/core/v8/V8BindingMacros.h - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Side by Side Diff: Source/bindings/core/v8/V8BindingMacros.h

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: drop throw_expression, re-add set_expression Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 19 matching lines...) Expand all Loading...
30	30

31 #ifndef V8BindingMacros_h	31 #ifndef V8BindingMacros_h

32 #define V8BindingMacros_h	32 #define V8BindingMacros_h

33	33

34 namespace blink {	34 namespace blink {

35	35

36 // Naming scheme:	36 // Naming scheme:

37 // TO*_RETURNTYPE[_ARGTYPE]...	37 // TO*_RETURNTYPE[_ARGTYPE]...

38 // ...using _DEFAULT instead of _ANY..._ANY when returing a default value.	38 // ...using _DEFAULT instead of _ANY..._ANY when returing a default value.

39	39

40 #define TONATIVE_EXCEPTION(type, var, value) \

41 type var; \

42 { \

43 v8::TryCatch block; \

44 var = (value); \

45 if (UNLIKELY(block.HasCaught())) \

46 return block.ReThrow(); \

47 }

48

49 #define TONATIVE_VOID_INTERNAL(var, value) \

50 var = (value); \

51 if (UNLIKELY(block.HasCaught())) \

52 return;

53

54 #define TONATIVE_VOID(type, var, value) \	40 #define TONATIVE_VOID(type, var, value) \

55 type var; \	41 type var; \

56 { \	42 { \

57 v8::TryCatch block; \	43 v8::TryCatch block; \

58 V8RethrowTryCatchScope rethrow(block); \	44 V8RethrowTryCatchScope rethrow(block); \

59 TONATIVE_VOID_INTERNAL(var, value); \	45 var = (value); \

	46 if (UNLIKELY(block.HasCaught())) \

	47 return; \

60 }	48 }

61	49

62 #define TONATIVE_DEFAULT(type, var, value, retVal) \	50 #define TONATIVE_DEFAULT(type, var, value, retVal) \

63 type var; \	51 type var; \

64 { \	52 { \

65 v8::TryCatch block; \	53 v8::TryCatch block; \
	bashi 2015/02/25 04:44:35 BTW, should we use V8RethrowTryCatchScope here (li BTW, should we use V8RethrowTryCatchScope here (like TONATIVE_VOID) ? Jens Widell 2015/02/25 07:37:10 There's no real reason for TONATIVE_VOID and TONAT Show quoted text On 2015/02/25 04:44:35, bashi1 wrote: > BTW, should we use V8RethrowTryCatchScope here (like TONATIVE_VOID) ? There's no real reason for TONATIVE_VOID and TONATIVE_DEFAULT to use different patterns, for sure. But I don't think there's really a reason for either to use V8RethrowTryCatchScope either; they're simple enough that just calling block.ReThrow() directly makes more sense, IMO. So I think I'll rather change TONATIVE_VOID() to not use it. (Both these macros are going to be removed soon, I think.) Jens Widell 2015/02/25 07:49:43 Done. Show quoted text On 2015/02/25 07:37:10, Jens Widell wrote: > So I think I'll rather change TONATIVE_VOID() to not use it. Done.
66 var = (value); \	54 var = (value); \

67 if (UNLIKELY(block.HasCaught())) { \	55 if (UNLIKELY(block.HasCaught())) { \

68 block.ReThrow(); \	56 block.ReThrow(); \

69 return retVal; \	57 return retVal; \

70 } \	58 } \

71 }	59 }

72	60

73 // We need to cancel the exception propergation when we return a rejected

74 // Promise.

75 #define TONATIVE_VOID_PROMISE_INTERNAL(var, value, info) \

76 var = (value); \

77 if (UNLIKELY(block.HasCaught())) { \

78 v8SetReturnValue(info, ScriptPromise::rejectRaw(info.GetIsolate(), block .Exception())); \

79 block.Reset(); \

80 return; \

81 }

82

83 #define TONATIVE_VOID_PROMISE(type, var, value, info) \

84 type var; \

85 { \

86 v8::TryCatch block; \

87 TONATIVE_VOID_PROMISE_INTERNAL(var, value, info); \

88 }

89

90

91 #define TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(var, value, exceptionState) \

92 var = (value); \

93 if (UNLIKELY(exceptionState.throwIfNeeded())) \

94 return; \

95

96 #define TONATIVE_VOID_EXCEPTIONSTATE(type, var, value, exceptionState) \	61 #define TONATIVE_VOID_EXCEPTIONSTATE(type, var, value, exceptionState) \

97 type var; \	62 type var(value); \

98 var = (value); \

99 if (UNLIKELY(exceptionState.throwIfNeeded())) \	63 if (UNLIKELY(exceptionState.throwIfNeeded())) \

100 return;	64 return;

101	65

102 #define TONATIVE_VOID_EXCEPTIONSTATE_ARGINTERNAL(value, exceptionState) \

103 (value); \

104 if (UNLIKELY(exceptionState.throwIfNeeded())) \

105 return;

106

107 #define TONATIVE_DEFAULT_EXCEPTIONSTATE(type, var, value, exceptionState, retVal ) \

108 type var = (value); \

109 if (UNLIKELY(exceptionState.throwIfNeeded())) \

110 return retVal;

111

112 // We need to cancel the exception propergation when we return a rejected

113 // Promise.

114 #define TONATIVE_VOID_EXCEPTIONSTATE_PROMISE_INTERNAL(var, value, exceptionState , info, scriptState) \

115 var = (value); \

116 if (UNLIKELY(exceptionState.hadException())) { \

117 v8SetReturnValue(info, exceptionState.reject(scriptState).v8Value()); \

118 return; \

119 }

120

121 #define TONATIVE_VOID_EXCEPTIONSTATE_PROMISE(type, var, value, exceptionState, i nfo, scriptState) \

122 type var; \

123 TONATIVE_VOID_EXCEPTIONSTATE_PROMISE_INTERNAL(var, value, exceptionState, in fo, scriptState);

124

125 // type is an instance of class template V8StringResource<>,	66 // type is an instance of class template V8StringResource<>,

126 // but Mode argument varies; using type (not Mode) for consistency	67 // but Mode argument varies; using type (not Mode) for consistency

127 // with other macros and ease of code generation	68 // with other macros and ease of code generation

128 #define TOSTRING_VOID(type, var, value) \	69 #define TOSTRING_VOID(type, var, value) \

129 type var(value); \	70 type var(value); \

130 if (UNLIKELY(!var.prepare())) \	71 if (UNLIKELY(!var.prepare())) \

131 return;	72 return;

132	73

133 #define TOSTRING_VOID_INTERNAL(var, value) \

134 var = (value); \

135 if (UNLIKELY(!var.prepare())) \

136 return;

137

138 #define TOSTRING_VOID_EXCEPTIONSTATE(type, var, value, exceptionState) \

139 type var(value); \

140 if (UNLIKELY(!var.prepare(exceptionState))) \

141 return;

142

143 #define TOSTRING_DEFAULT(type, var, value, retVal) \	74 #define TOSTRING_DEFAULT(type, var, value, retVal) \

144 type var(value); \	75 type var(value); \

145 if (UNLIKELY(!var.prepare())) \	76 if (UNLIKELY(!var.prepare())) \

146 return retVal;	77 return retVal;

147	78

148 // We need to cancel the exception propagation when we return a rejected

149 // Promise.

150 #define TOSTRING_VOID_EXCEPTIONSTATE_PROMISE_INTERNAL(var, value, exceptionState , info, scriptState) \

151 var = (value); \

152 if (UNLIKELY(!var.prepare(exceptionState))) { \

153 v8SetReturnValue(info, exceptionState.reject(scriptState).v8Value()); \

154 return; \

155 }

156

157 } // namespace blink	79 } // namespace blink

158	80

159 #endif // V8BindingMacros_h	81 #endif // V8BindingMacros_h

OLD	NEW

« no previous file with comments | « no previous file | Source/bindings/core/v8/V8StringResource.h » ('j') | Source/bindings/scripts/v8_types.py » ('J')