Issue 946973004: Revert of Correctly propagate terminate exception in TryCall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 946973004: Revert of Correctly propagate terminate exception in TryCall. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach

Modified:
5 years, 10 months ago

Reviewers:
Igor Sheludko, Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Correctly propagate terminate exception in TryCall. (patchset #2 id:20001 of https://codereview.chromium.org/928193002/) Reason for revert: See crbug.com/460412 and crbug.com/460356. Reverting on master in order to roll from master again soon. Original issue's description: > Correctly propagate terminate exception in TryCall. > > BUG=v8:3892 > LOG=Y > > Committed: https://crrev.com/a49b55b78844557b65a98e7a77dd26078157ed7f > Cr-Commit-Position: refs/heads/master@{#26685} TBR=ishell@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3892 Committed: https://crrev.com/035b144b166c3d2b9e890387223f83021b67f67c Cr-Commit-Position: refs/heads/master@{#26792}

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -36 lines)			Patch
	M	src/execution.cc	View		1 chunk	+7 lines, -6 lines	0 comments	Download
	M	test/cctest/test-thread-termination.cc	View		1 chunk	+0 lines, -30 lines	0 comments	Download

Total messages: 5 (0 generated)

Michael Achenbach

Created Revert of Correctly propagate terminate exception in TryCall.

5 years, 10 months ago (2015-02-23 07:15:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946973004/1

5 years, 10 months ago (2015-02-23 07:17:11 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-23 07:17:38 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/035b144b166c3d2b9e890387223f83021b67f67c
Cr-Commit-Position: refs/heads/master@{#26792}