Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 946963002: Add GN build files for apple_sample_code and molokocacao targets. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
CC:
chromium-reviews, brettw, Dirk Pranke, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GN build files for apple_sample_code and molokocacao targets. This can be tested with the following command lines in a Mac computer: $ gn gen out-gn $ ninja -C out-gn apple_sample_code molokocacao BUG=None TEST=see above R=avi@chromium.org,mark@chromium.org Committed: https://crrev.com/9e7cf706813c75c95c5f24c3bacb5ea24ec0e972 Cr-Commit-Position: refs/heads/master@{#317650}

Patch Set 1 #

Patch Set 2 : no-copies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M BUILD.gn View 1 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/apple_sample_code/BUILD.gn View 1 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/molokocacao/BUILD.gn View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
tfarina
apple_sample_code -> Avi molokocacao -> Mark PTAL.
5 years, 10 months ago (2015-02-22 17:26:47 UTC) #1
Avi (use Gerrit)
I don't know GN but that looks quite reasonable. LGTM stampity stamp
5 years, 10 months ago (2015-02-22 18:09:29 UTC) #2
Nico
lgtm
5 years, 10 months ago (2015-02-22 20:23:07 UTC) #4
Mark Mentovai
LGTM
5 years, 10 months ago (2015-02-23 16:32:35 UTC) #5
Dirk Pranke
lgtm. I might re-upload this with --no-find-copies just to make the diff a bit more ...
5 years, 10 months ago (2015-02-23 18:50:21 UTC) #7
brettw
lgtm
5 years, 10 months ago (2015-02-23 19:24:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946963002/20001
5 years, 10 months ago (2015-02-23 20:26:23 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-23 21:13:59 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 21:14:28 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e7cf706813c75c95c5f24c3bacb5ea24ec0e972
Cr-Commit-Position: refs/heads/master@{#317650}

Powered by Google App Engine
This is Rietveld 408576698