Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 946943003: Revert of for-of should throw if result object is not an object (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 9 months ago
Reviewers:
wingo, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of for-of should throw if result object is not an object (patchset #4 id:60001 of https://codereview.chromium.org/929733003/) Reason for revert: Broke compile Original issue's description: > for-of should throw if result object is not an object > > This is done using desugaring. Before this we had: > > result = iterator.next() > > with this we instead do: > > !%_IsSpecObject(result = iterator.next()) && > %ThrowIteratorResultNotAnObject(result) > > BUG=v8:3916 > LOG=N > > Committed: https://crrev.com/ab2591ed9332086581ee25ef735cd1b3bbd7e2f0 > Cr-Commit-Position: refs/heads/master@{#26806} TBR=adamk@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -278 lines) Patch
M src/ast.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast-value-factory.h View 1 chunk +32 lines, -34 lines 0 comments Download
M src/parser.cc View 1 chunk +3 lines, -29 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +175 lines, -176 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M test/mjsunit/es6/iteration-semantics.js View 2 chunks +3 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
arv (Not doing code reviews)
Created Revert of for-of should throw if result object is not an object
5 years, 10 months ago (2015-02-23 23:52:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946943003/1
5 years, 10 months ago (2015-02-23 23:52:18 UTC) #2
commit-bot: I haz the power
Failed to apply the patch.
5 years, 10 months ago (2015-02-23 23:52:33 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 23:52:33 UTC) #6
Failed to apply the patch.

Powered by Google App Engine
This is Rietveld 408576698