Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/browser/BUILD.gn

Issue 946873002: chrome/browser: Enable more deps that were already converted to GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 1f084a922c40f5182e6bffec384ee1f9ea149361..89a043f7464941d47da418e62d03aadf11605b67 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -280,7 +280,7 @@ static_library("browser") {
"//v8",
## TODO(tonyg): Remove this dependency (crbug.com/280157).
- #"../testing/perf/perf_test.gyp:*", TODO(GYP)
+ "//testing/perf",
Nico 2015/02/22 20:19:09 this adds a dep on perf, while the lhs was a dep o
tfarina 2015/02/22 21:18:33 it is the same. //testing/perf:perf is the GN tar
Dirk Pranke 2015/02/23 18:56:21 tfarina's right, //testing/perf is the GN equivale
]
} else { # iOS
sources +=
@@ -622,7 +622,7 @@ static_library("browser") {
if (is_mac) {
deps += [
"//third_party/google_toolbox_for_mac",
- #"../third_party/mozilla/mozilla.gyp:mozilla", TODO(GYP)
+ "//third_party/mozilla",
]
libs += [
"Accelerate.framework",
« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698