chrome/browser: Enable more deps that were already converted to GN.

chrome/browser: Enable more deps that were already converted to GN.

This fixes three more TODO(GYP)s.

BUG=None
TEST=trybots
R=thakis@chromium.org

Committed: https://crrev.com/2289630132c8e3ff98ea978371527bea3966ce4c
Cr-Commit-Position: refs/heads/master@{#317652}

[Nico, 2015-02-22 20:19:09]

https://codereview.chromium.org/946873002/diff/1/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/946873002/diff/1/chrome/browser/BUILD.gn#newc...
chrome/browser/BUILD.gn:283: "//testing/perf",
this adds a dep on perf, while the lhs was a dep on perf_test

[tfarina, 2015-02-22 21:18:33]

https://codereview.chromium.org/946873002/diff/1/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/946873002/diff/1/chrome/browser/BUILD.gn#newc...
chrome/browser/BUILD.gn:283: "//testing/perf",
On 2015/02/22 20:19:09, Nico wrote:
> this adds a dep on perf, while the lhs was a dep on perf_test

it is the same.

//testing/perf:perf is the GN target of testing/perf/perf_test.gyp:perf_test

Unless I'm reading something really wrong ;)

[Dirk Pranke, 2015-02-23 18:56:21]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-02-23 18:56:21]

lgtm

https://codereview.chromium.org/946873002/diff/1/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/946873002/diff/1/chrome/browser/BUILD.gn#newc...
chrome/browser/BUILD.gn:283: "//testing/perf",
On 2015/02/22 21:18:33, tfarina wrote:
> On 2015/02/22 20:19:09, Nico wrote:
> > this adds a dep on perf, while the lhs was a dep on perf_test
> 
> it is the same.
> 
> //testing/perf:perf is the GN target of testing/perf/perf_test.gyp:perf_test
> 
> Unless I'm reading something really wrong ;)

tfarina's right, //testing/perf is the GN equivalent of GYP's
testing/perf/perf_test.gyp.

[brettw, 2015-02-23 19:06:14]

brettw@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2015-02-23 19:06:14]

lgtm

[Nico, 2015-02-23 19:19:27]

On 2015/02/23 18:56:21, Dirk Pranke wrote:
> lgtm
> 
> https://codereview.chromium.org/946873002/diff/1/chrome/browser/BUILD.gn
> File chrome/browser/BUILD.gn (right):
> 
>
https://codereview.chromium.org/946873002/diff/1/chrome/browser/BUILD.gn#newc...
> chrome/browser/BUILD.gn:283: "//testing/perf",
> On 2015/02/22 21:18:33, tfarina wrote:
> > On 2015/02/22 20:19:09, Nico wrote:
> > > this adds a dep on perf, while the lhs was a dep on perf_test
> > 
> > it is the same.
> > 
> > //testing/perf:perf is the GN target of testing/perf/perf_test.gyp:perf_test
> > 
> > Unless I'm reading something really wrong ;)
> 
> tfarina's right, //testing/perf is the GN equivalent of GYP's
> testing/perf/perf_test.gyp.

That sounds like a bug in the gn file: The gyp name makes it clear that this is
test code that shouldn't be used in prod code. The gn name doesn't make this
clear.

[Nico, 2015-02-23 19:19:49]

(but this cl lgtm then)

[brettw, 2015-02-23 19:20:23]

We should just mark the perf target testonly so GN will catch you if you do the
wrong thing.

[tfarina, 2015-02-23 20:28:01]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-02-23 20:28:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, brettw@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/946873002/#ps20001 (title:
"REBASE")

[commit-bot: I haz the power, 2015-02-23 20:28:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/946873002/20001

[commit-bot: I haz the power, 2015-02-23 21:18:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-23 21:18:40]

Patchset 2 (id:??) landed as
https://crrev.com/2289630132c8e3ff98ea978371527bea3966ce4c
Cr-Commit-Position: refs/heads/master@{#317652}