Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 946833004: Reland of "Expose events in workers as per latest DOM specification" (Closed)

Created:
5 years, 10 months ago by sadrul
Modified:
5 years, 9 months ago
Reviewers:
tkent, kinuko
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland of "Expose events in workers as per latest DOM specification" The original CL was reverted (https://codereview.chromium.org/262173006/) because of some thread safety issues. There has been some work since then related to thread-safety (e.g. crash if DEFINE_STATIC_LOCAL variables are misused). So try landing this change again and see if we can determine the cause of the issues that lead to the earlier revert. This reverts commit 90cb21f40c8db15868c4e605a0b79fed9b77eb50. BUG=370011 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190921

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Messages

Total messages: 7 (2 generated)
sadrul
Hi! One of the reasons for this patch was reverted earlier was concerns about the ...
5 years, 10 months ago (2015-02-26 02:59:08 UTC) #2
tkent
lgtm
5 years, 10 months ago (2015-02-26 04:40:46 UTC) #3
kinuko
lgtm
5 years, 10 months ago (2015-02-26 07:36:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946833004/80001
5 years, 9 months ago (2015-02-26 14:12:22 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 15:16:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190921

Powered by Google App Engine
This is Rietveld 408576698