Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 946823002: Sync CharacterData and related interfaces with the spec (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync CharacterData and related interfaces with the spec https://dom.spec.whatwg.org/#interface-characterdata https://dom.spec.whatwg.org/#interface-comment https://dom.spec.whatwg.org/#interface-processinginstruction https://dom.spec.whatwg.org/#interface-text This replaces |length| with |count| in a few places. The implementation already uses |count| as the argument name. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190625

Patch Set 1 #

Patch Set 2 : of #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M Source/core/dom/CharacterData.idl View 1 chunk +6 lines, -7 lines 0 comments Download
M Source/core/dom/Comment.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/ProcessingInstruction.idl View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/Text.idl View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
of
5 years, 10 months ago (2015-02-21 19:55:42 UTC) #1
philipj_slow
haraken@, you're in a good timezone for me now, but please let me know of ...
5 years, 10 months ago (2015-02-22 03:39:17 UTC) #3
haraken
LGTM > haraken@, you're in a good timezone for me now, but please let me ...
5 years, 10 months ago (2015-02-22 08:01:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946823002/20001
5 years, 10 months ago (2015-02-22 09:35:11 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-22 10:57:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190625

Powered by Google App Engine
This is Rietveld 408576698