Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 946813005: Port Sky widgets demo to Dart (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel
CC:
eseidel, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Port Sky widgets demo to Dart This CL updates sky-box, sky-button, sky-checkbox, sky-input, and sky-radio to work in Dart. We don't have a data binding system yet, so there's a bit more plumbing in the code. This CL adds support for sky-element@attributes, which lets you specify which attributes your element supports. We use this information to synthesize getters and setters for those attributes and to dispatch to mumbleChanged methods when the attributes change. I've also wrapped the widgets demo itself in a sky-scrollable so the whole thing scrolls. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9350c53370050ad02fb93f84ba0ea476e83a7fdc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -226 lines) Patch
M sky/engine/core/dom/Element.idl View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/widgets/index.sky View 1 chunk +2 lines, -82 lines 0 comments Download
A sky/examples/widgets/widget-root.sky View 1 chunk +93 lines, -0 lines 0 comments Download
M sky/framework/dom-serializer.sky View 1 chunk +5 lines, -0 lines 0 comments Download
M sky/framework/sky-box.sky View 2 chunks +25 lines, -9 lines 0 comments Download
M sky/framework/sky-button.sky View 2 chunks +24 lines, -19 lines 0 comments Download
M sky/framework/sky-checkbox.sky View 2 chunks +38 lines, -20 lines 0 comments Download
M sky/framework/sky-element.sky View 4 chunks +84 lines, -7 lines 0 comments Download
M sky/framework/sky-input.sky View 2 chunks +33 lines, -34 lines 0 comments Download
M sky/framework/sky-radio.sky View 3 chunks +70 lines, -54 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-22 05:09:19 UTC) #1
eseidel
lgtm
5 years, 10 months ago (2015-02-23 16:01:48 UTC) #3
abarth-chromium
5 years, 10 months ago (2015-02-23 16:30:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9350c53370050ad02fb93f84ba0ea476e83a7fdc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698