Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 946813003: Check context id when deciding if a layer is in existing sorting context (Closed)

Created:
5 years, 10 months ago by Ian Vollick
Modified:
5 years, 10 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check context id when deciding if a layer is in existing sorting context BUG=421946, 456601 Committed: https://crrev.com/089b34e45ac96971bc0aa4559d91109d5bcb9bf4 Cr-Commit-Position: refs/heads/master@{#317634}

Patch Set 1 #

Patch Set 2 : add unit test #

Total comments: 2

Patch Set 3 : Whoops. Not allowed to include tuple after all. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
M cc/trees/layer_tree_host_common.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Ian Vollick
https://codereview.chromium.org/946813003/diff/20001/cc/trees/layer_tree_host_common_unittest.cc File cc/trees/layer_tree_host_common_unittest.cc (right): https://codereview.chromium.org/946813003/diff/20001/cc/trees/layer_tree_host_common_unittest.cc#newcode9 cc/trees/layer_tree_host_common_unittest.cc:9: #include <tuple> Although not needed for my changes, the ...
5 years, 10 months ago (2015-02-21 23:00:49 UTC) #2
enne (OOO)
lgtm (We need to get Andrew's patch landed and get rid of this sorting once ...
5 years, 10 months ago (2015-02-23 19:01:50 UTC) #3
Ian Vollick
On 2015/02/23 19:01:50, enne wrote: > lgtm > > (We need to get Andrew's patch ...
5 years, 10 months ago (2015-02-23 19:10:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946813003/40001
5 years, 10 months ago (2015-02-23 19:12:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61830)
5 years, 10 months ago (2015-02-23 19:14:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946813003/40001
5 years, 10 months ago (2015-02-23 19:52:25 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-23 20:01:58 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 20:02:42 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/089b34e45ac96971bc0aa4559d91109d5bcb9bf4
Cr-Commit-Position: refs/heads/master@{#317634}

Powered by Google App Engine
This is Rietveld 408576698