Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/browser/resources/inspect/inspect.css

Issue 946713002: chrome://inspect sticky nav bar & padding under anchor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace position:fixed with max-height:100vh Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/inspect/inspect.css
diff --git a/chrome/browser/resources/inspect/inspect.css b/chrome/browser/resources/inspect/inspect.css
index bf0a1107eac9e851b78cafc44ead77381fa9a8fa..a50292c45d0aa9db1f381dbf721a10b6e64bc245 100644
--- a/chrome/browser/resources/inspect/inspect.css
+++ b/chrome/browser/resources/inspect/inspect.css
@@ -7,7 +7,6 @@ body {
font-size: 13px;
margin: 0;
min-width: 47em;
- padding: 20px 20px 65px 0;
}
.hidden {
@@ -29,11 +28,17 @@ img {
}
#navigation {
+ box-sizing: border-box;
pfeldman 2015/03/02 17:15:31 Lets do * { box-sizing: border-box; }
robwu 2015/04/04 09:18:48 Done. I've updated some values because of the effe
+ max-height: 100vh;
pfeldman 2015/03/02 17:15:31 We don't use vh much in the source base.
robwu 2015/04/04 09:18:48 What's the issue with vh? 100vh is exactly what we
pfeldman 2015/04/04 09:32:30 what is the effect you are trying to achieve? isn'
robwu 2015/04/04 09:39:37 When the window is large enough, then there is no
+ overflow: auto;
+ padding-top: 20px;
width: 150px;
}
#content {
-webkit-flex: 1;
+ max-height: 100vh;
+ overflow: auto;
}
#caption {
@@ -70,6 +75,9 @@ img {
color: #999;
}
+#content > div {
+ padding: 20px 20px 65px 0;
+}
#content > div:not(.selected) {
display: none;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698