Fix GN os, cpu defaults for Android builds.

build/config/BUILDCONFIG.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # =============================================================================
 # BUILD FLAGS
 # =============================================================================
 #
 # This block lists input arguments to the build, along with their default
 # values. GN requires listing them explicitly so it can validate input and have
@@ skipping 19 matching lines @@
   } else {
     target_os = host_os
   }
 }
 
 if (target_cpu == "") {
   if (defined(cpu_arch)) {
     # If cpu_arch is defined, it was set in an args file and needs to be
     # used for backwards-compatibility.
     target_cpu = cpu_arch
+  } else if (target_os == "android") {
+    # If we're building for Android, we should assume that we want to
+    # build for ARM by default, not the host_cpu (which is likely x64).
+    # This allows us to not have to specify both target_os and target_cpu
+    # on the command line.
+    target_cpu = "arm"
   } else {
     target_cpu = host_cpu
   }
 }
 
 if (current_cpu == "") {
   current_cpu = target_cpu
 }
 if (current_os == "") {
   current_os = target_os
@@ skipping 51 matching lines @@
   # Compile for Thread Sanitizer to find threading bugs.
   is_tsan = false
 
   if (current_os == "chromeos") {
     # Allows the target toolchain to be injected as arguments. This is needed
     # to support the CrOS build system which supports per-build-configuration
     # toolchains.
     cros_use_custom_toolchain = false
   }
 
-  # TODO(dpranke): Replace target_arch with target_cpu.
-
-  # Architecture of the target device. For Android builds, this will be
-  # equal to the current_cpu of the default toolchain. When checking
-  # the CPU architecture for source files and build dependencies you
-  # should almost alway use current_cpu instead. current_cpu is the
-  # architecture of the current toolchain and allows cross-compiles
-  # (compiling the same target for multiple toolchains in the same build)
-  # to work.
-  target_arch = "arm"

[Dirk Pranke, 2015/02/20 20:06:50]

I think it's perhaps best to just cut straight to getting users to specify
target_cpu instead of target_arch, if they need to do an x86 android build (or
some other variant). I'm not even sure if any non-arm Android build actually
works at the moment, so I don't know if anyone is actually using non-arm values,


It would not be hard to support target_arch for backwards compatibility for some
time, though, if that would be preferred.

[cjhopman, 2015/02/20 20:28:19]

Make them use target_cpu sgtm.

-
   # TODO(brettw) remove this flag (and therefore enable linking all targets) on
   # Windows when we have sufficient bot capacity. In the meantime, you can
   # enable linking for local compiles.
   link_chrome_on_windows = true
 }
 
 # TODO(dpranke): Remove these asserts when os and cpu_arch are removed.
 assert(current_cpu == cpu_arch)
 assert(current_os == os)
 
@@ skipping 77 matching lines @@
   is_chromeos = false
   is_ios = false
   is_linux = true
   is_mac = false
   is_nacl = false
   is_posix = true
   is_win = false
 }
 
 # =============================================================================
-# CPU ARCHITECTURE
-# =============================================================================
-
-if (is_android) {
-  # TODO(cjhopman): enable this assert once bots are updated to not set
-  # current_cpu.
-  #assert(current_cpu == host_cpu, "Android device target architecture should
-  #    be set with 'target_arch', not 'current_cpu'")
-  current_cpu = target_arch

[Dirk Pranke, 2015/02/20 20:06:50]

This was the thing I broke in https://codereview.chromium.org/913373002/ ; this
should've been target_cpu, not current_cpu.

-}
-
-# =============================================================================
 # SOURCES FILTERS
 # =============================================================================
 #
 # These patterns filter out platform-specific files when assigning to the
 # sources variable. The magic variable |sources_assignment_filter| is applied
 # to each assignment or appending to the sources variable and matches are
 # automatcally removed.
 #
 # Note that the patterns are NOT regular expressions. Only "*" and "\b" (path
 # boundary = end of string or slash) are supported, and the entire string
@@ skipping 526 matching lines @@
       }
       if (defined(invoker.testonly)) {
         testonly = invoker.testonly
       }
       if (defined(invoker.visibility)) {
         visibility = invoker.visibility
       }
     }
   }
 }