Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 946623002: [Code cleanup]Remove webui keyboard mojo binding (Closed)

Created:
5 years, 10 months ago by bshe
Modified:
5 years, 10 months ago
Reviewers:
sadrul
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Code cleanup]Remove webui keyboard mojo binding BUG=455057 TEST=none Committed: https://crrev.com/2b07a075b8b8ce3c5c2a08c000cd0c7118a937c3 Cr-Commit-Position: refs/heads/master@{#317598}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : remove unused function #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -455 lines) Patch
M ui/keyboard/BUILD.gn View 1 2 3 4 chunks +0 lines, -23 lines 0 comments Download
M ui/keyboard/keyboard.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/keyboard/keyboard.cc View 1 2 2 chunks +0 lines, -14 lines 0 comments Download
M ui/keyboard/keyboard.gyp View 1 2 3 5 chunks +1 line, -22 lines 0 comments Download
M ui/keyboard/keyboard_resources.grd View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/keyboard/resources/index.html View 1 1 chunk +0 lines, -1 line 0 comments Download
D ui/keyboard/webui/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/keyboard/webui/keyboard.mojom View 1 chunk +0 lines, -21 lines 0 comments Download
D ui/keyboard/webui/vk_mojo_handler.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ui/keyboard/webui/vk_mojo_handler.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D ui/keyboard/webui/vk_webui_controller.h View 1 chunk +0 lines, -72 lines 0 comments Download
D ui/keyboard/webui/vk_webui_controller.cc View 1 chunk +0 lines, -118 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bshe
Hi Sadrul. Do you mind to take a look at this CL? I removed webui ...
5 years, 10 months ago (2015-02-20 20:33:14 UTC) #2
sadrul
LGTM!
5 years, 10 months ago (2015-02-23 16:45:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946623002/60001
5 years, 10 months ago (2015-02-23 16:59:52 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-23 17:03:11 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 17:03:47 UTC) #7
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/2b07a075b8b8ce3c5c2a08c000cd0c7118a937c3
Cr-Commit-Position: refs/heads/master@{#317598}

Powered by Google App Engine
This is Rietveld 408576698