Issue 9466028: aura: Repost click events that cause a menu to hide itself.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9466028: aura: Repost click events that cause a menu to hide itself.

Created:
8 years, 10 months ago by sadrul

Modified:
6 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Repost click events that cause a menu to hide itself. BUG=114536 TEST=none

Patch Set 2 : . #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -9 lines)			Patch
M	ui/aura/event.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	ui/views/controls/menu/menu_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/menu/menu_controller.cc	View	1	7 chunks	+47 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

This is an alternate fix for the bug (the other one: http://codereview.chromium.org/9456013/). I cannot test ...

8 years, 10 months ago (2012-02-24 23:23:24 UTC) #1

Ben Goodger (Google)

LGTM http://codereview.chromium.org/9466028/diff/1/ui/views/controls/menu/menu_controller.cc File ui/views/controls/menu/menu_controller.cc (right): http://codereview.chromium.org/9466028/diff/1/ui/views/controls/menu/menu_controller.cc#newcode1947 ui/views/controls/menu/menu_controller.cc:1947: #endif // defined(OS_WIN) // defined(USE_AURA)

8 years, 10 months ago (2012-02-24 23:26:15 UTC) #2

sadrul

8 years, 10 months ago (2012-02-24 23:30:28 UTC) #3

http://codereview.chromium.org/9466028/diff/1/ui/views/controls/menu/menu_con...
File ui/views/controls/menu/menu_controller.cc (right):

http://codereview.chromium.org/9466028/diff/1/ui/views/controls/menu/menu_con...
ui/views/controls/menu/menu_controller.cc:1947: #endif  // defined(OS_WIN)
On 2012/02/24 23:26:15, Ben Goodger (Google) wrote:
> // defined(USE_AURA)

Done.

Expand Messages | Collapse Messages

Issue 9466028: aura: Repost click events that cause a menu to hide itself.

Description

Patch Set 1 #

Patch Set 2 : . #

Messages