Teach SkyShell how to listen for VIEW intents of sky: urls.

sky/shell/ui/engine.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sky/shell/ui/engine.h"
 
 #include "base/bind.h"
 #include "sky/engine/public/platform/WebInputEvent.h"
 #include "sky/engine/public/web/Sky.h"
 #include "sky/engine/public/web/WebLocalFrame.h"
@@ skipping 21 matching lines @@
 }
 
 base::WeakPtr<Engine> Engine::GetWeakPtr() {
   return weak_factory_.GetWeakPtr();
 }
 
 void Engine::Init(mojo::ScopedMessagePipeHandle service_provider) {
   platform_impl_.reset(new PlatformImpl(
       mojo::MakeProxy<mojo::ServiceProvider>(service_provider.Pass())));
   blink::initialize(platform_impl_.get());
-
-  web_view_ = blink::WebView::create(this);
-  web_view_->setMainFrame(blink::WebLocalFrame::create(this));
-  web_view_->mainFrame()->load(
-      GURL("http://domokit.github.io/sky/examples/spinning-square.sky"));
 }
 
 void Engine::BeginFrame(base::TimeTicks frame_time) {
   double frame_time_sec = (frame_time - base::TimeTicks()).InSecondsF();
   double deadline_sec = frame_time_sec;
   double interval_sec = 1.0 / 60;
   blink::WebBeginFrameArgs args(frame_time_sec, deadline_sec, interval_sec);
 
   web_view_->beginFrame(args);
   web_view_->layout();
@@ skipping 12 matching lines @@
 
 void Engine::ConnectToViewportObserver(
     mojo::InterfaceRequest<ViewportObserver> request) {
   viewport_observer_binding_.Bind(request.Pass());
 }
 
 void Engine::OnViewportMetricsChanged(int width, int height,
                                       float device_pixel_ratio) {
   physical_size_.SetSize(width, height);
   device_pixel_ratio_ = device_pixel_ratio;
-  web_view_->setDeviceScaleFactor(device_pixel_ratio);
-  gfx::SizeF size = gfx::ScaleSize(physical_size_, 1 / device_pixel_ratio);
+  if (web_view_)
+    UpdateWebViewSize();
+}
+
+void Engine::UpdateWebViewSize()
+{

[abarth-chromium, 2015/02/20 22:10:49]

Chromium style is to combine these lines.

+  CHECK(web_view_);

[abarth-chromium, 2015/02/20 22:10:49]

CHECK -> DCHECK

+  web_view_->setDeviceScaleFactor(device_pixel_ratio_);
+  gfx::SizeF size = gfx::ScaleSize(physical_size_, 1 / device_pixel_ratio_);
   // FIXME: We should be able to set the size of the WebView in floating point
   // because its in logical pixels.
   web_view_->resize(blink::WebSize(size.width(), size.height()));
 }
 
 void Engine::OnInputEvent(InputEventPtr event) {
   scoped_ptr<blink::WebInputEvent> web_event =
       ConvertEvent(event, device_pixel_ratio_);
   if (!web_event)
     return;
   web_view_->handleInputEvent(*web_event);
 }
 
+void Engine::LoadURL(const mojo::String& url) {
+  web_view_ = blink::WebView::create(this);
+  web_view_->setMainFrame(blink::WebLocalFrame::create(this));
+  UpdateWebViewSize();
+  web_view_->mainFrame()->load(GURL(url));
+}
+
 void Engine::initializeLayerTreeView() {
 }
 
 void Engine::scheduleVisualUpdate() {
   animator_->RequestFrame();
 }
 
 }  // namespace shell
 }  // namespace sky