Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 946583002: Add [TypeChecking=Interface] to the TextTrack interface (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, arv+blink, vivekg, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vivekg_samsung, Inactive, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add [TypeChecking=Interface] to the TextTrack interface Affects addCue and removeCue (no longer accepts any thing else as null.) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M LayoutTests/media/track/opera/interfaces/TextTrack/addCue.html View 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrack/removeCue.html View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/html/track/TextTrack.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/html/track/TextTrack.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 10 months ago (2015-02-20 15:32:10 UTC) #2
philipj_slow
lgtm
5 years, 10 months ago (2015-02-20 16:20:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946583002/1
5 years, 10 months ago (2015-02-20 16:22:27 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 22:10:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190585

Powered by Google App Engine
This is Rietveld 408576698