Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 946573002: AppBanner: add requirement for an 144x144 image/png icon. (Closed)

Created:
5 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 10 months ago
Reviewers:
gone
CC:
chromium-reviews, benwells
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AppBanner: add requirement for an 144x144 image/png icon. This requirement is only a requirement on the Manifest content. It is then up to the ManifestIconSelector to pick the best icon which might be a smaller one. BUG=457399 Committed: https://crrev.com/6c608b2ef8e522462355b2dadc721c608985b322 Cr-Commit-Position: refs/heads/master@{#317362}

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M chrome/browser/android/banners/app_banner_manager.cc View 1 3 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mlamouri (slow - plz ping)
I will work on some tests later. Landing this sounds a tad more urgent ;)
5 years, 10 months ago (2015-02-20 14:02:27 UTC) #2
gone
lgtm https://chromiumcodereview.appspot.com/946573002/diff/1/chrome/browser/android/banners/app_banner_manager.cc File chrome/browser/android/banners/app_banner_manager.cc (right): https://chromiumcodereview.appspot.com/946573002/diff/1/chrome/browser/android/banners/app_banner_manager.cc#newcode61 chrome/browser/android/banners/app_banner_manager.cc:61: if (size.width() >= 144 && size.height() >= 144) ...
5 years, 10 months ago (2015-02-20 17:36:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946573002/20001
5 years, 10 months ago (2015-02-20 18:42:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-20 19:08:14 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6c608b2ef8e522462355b2dadc721c608985b322 Cr-Commit-Position: refs/heads/master@{#317362}
5 years, 10 months ago (2015-02-20 19:09:02 UTC) #8
mlamouri (slow - plz ping)
5 years, 10 months ago (2015-02-24 12:28:43 UTC) #9
Message was sent while issue was closed.
+cc benwells@ fyi

Powered by Google App Engine
This is Rietveld 408576698