Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 946553004: [telemetry] - Rename benchmark_rerun_options to trace_rerun_options. (Closed)

Created:
5 years, 10 months ago by shatch
Modified:
5 years, 10 months ago
Reviewers:
sullivan, qyearsley
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[telemetry] - Rename benchmark_rerun_options to trace_rerun_options. Since these rerun options are intended to be used for tracing, makes sense to rename + this makes the names consistent with the dashboard. BUG= Committed: https://crrev.com/12bf6c6e4f42ae41274d8fde255aaed13f868045 Cr-Commit-Position: refs/heads/master@{#317408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/results/chart_json_output_formatter.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
shatch
5 years, 10 months ago (2015-02-20 20:32:01 UTC) #2
qyearsley
LGTM Note: This is updated on perf dashboard at cl/86807006.
5 years, 10 months ago (2015-02-20 20:38:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946553004/1
5 years, 10 months ago (2015-02-20 20:44:42 UTC) #5
sullivan
lgtm
5 years, 10 months ago (2015-02-20 20:48:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 21:43:55 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 21:44:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12bf6c6e4f42ae41274d8fde255aaed13f868045
Cr-Commit-Position: refs/heads/master@{#317408}

Powered by Google App Engine
This is Rietveld 408576698