Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 946553002: [turbofan] Fix several int vs size_t issues. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix several int vs size_t issues. R=svenpanne@chromium.org Committed: https://crrev.com/9c1407da781b38d66b6465118d41f61c66cba12b Cr-Commit-Position: refs/heads/master@{#26789}

Patch Set 1 #

Patch Set 2 : Fix. #

Patch Set 3 : REBASE. Fix Win64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -84 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 2 11 chunks +15 lines, -15 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 6 chunks +15 lines, -13 lines 0 comments Download
M src/compiler/code-generator.cc View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M src/compiler/code-generator-impl.h View 1 chunk +17 lines, -13 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 10 chunks +14 lines, -12 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/scheduler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 13 chunks +19 lines, -17 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Benedikt Meurer
5 years, 10 months ago (2015-02-20 12:35:15 UTC) #1
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-20 12:41:01 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-02-20 12:45:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946553002/20001
5 years, 10 months ago (2015-02-20 12:46:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/2138)
5 years, 10 months ago (2015-02-20 14:23:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/2138)
5 years, 10 months ago (2015-02-20 14:23:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946553002/40001
5 years, 10 months ago (2015-02-23 05:21:30 UTC) #12
commit-bot: I haz the power
Failed to commit the patch.
5 years, 10 months ago (2015-02-23 05:42:59 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-23 05:44:10 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 05:44:13 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/9c1407da781b38d66b6465118d41f61c66cba12b
Cr-Commit-Position: refs/heads/master@{#26789}

Powered by Google App Engine
This is Rietveld 408576698