content/browser/frame_host/navigator_impl.cc - Issue 946543003: PlzNavigate: have renderer-initiated navigations be same-process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 946543003: PlzNavigate: have renderer-initiated navigations be same-process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: New test, moved out change and other minor changes. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_unittest.cc ('k') | content/browser/frame_host/navigator_impl_unittest.cc » ('j') | content/browser/frame_host/navigator_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index 72f9f8702c8fa0509b62e2bbdbf6a67661c0bf9e..1bab14d4ba73d7f8d03a53d809fdb2558e368b27 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -853,6 +853,9 @@ void NavigatorImpl::RequestNavigation(

navigation_request_map_.get(frame_tree_node_id);

request_to_send->SetWaitingForRendererResponse();

frame_tree_node->current_frame_host()->DispatchBeforeUnload(true);

+ if (delegate_)

+ delegate_->DidStartNavigationToPendingEntry(entry.GetURL(), reload_type);

clamy 2015/03/06 13:43:09 Don't forget to remove this :).

carlosk 2015/03/06 15:44:15 Sorry about that. *Really* done now.

}

void NavigatorImpl::BeginNavigation(FrameTreeNode* frame_tree_node) {