PlzNavigate: have renderer-initiated navigations be same-process

content/browser/frame_host/render_frame_host_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_manager.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 702 matching lines @@
   SiteInstance* current_site_instance = render_frame_host_->GetSiteInstance();
 
   scoped_refptr<SiteInstance> dest_site_instance = GetSiteInstanceForNavigation(
       request.common_params().url, request.source_site_instance(),
       request.dest_site_instance(), request.common_params().transition,
       request.restore_type() != NavigationEntryImpl::RESTORE_NONE,
       request.is_view_source());
   // The appropriate RenderFrameHost to commit the navigation.
   RenderFrameHostImpl* navigation_rfh = nullptr;
 
-  // TODO(carlosk): do not swap processes for renderer initiated navigations
-  // (see crbug.com/440266).
+  // TODO(carlosk): Once there is support for cross-process scripting remove the

[clamy, 2015/03/06 13:43:09]

I think you should add a little more explanation on why this is safe to do.
Something like: "Renderer-initiated navigations that may require a SiteInstance
swap are sent to the browser via the OpenURL IPC, and are afterwards treated as
browser-initiated navigations. The only NavigationRequests marked as
renderer-initiated were created after receiving a BeginNavigation IPC, and
should proceed in the same renderer that sent the IPC."

[carlosk, 2015/03/06 15:44:15]

Done. I didn't realized/remembered that situation but indeed an "open in new
tab" renderer initiated navigation will follow that other path.

+  // check for renderer-initiated navigations. See crbug.com/440266.
   if (current_site_instance == dest_site_instance.get() ||
+      !request.browser_initiated() ||
       (!frame_tree_node_->IsMainFrame() &&
        !base::CommandLine::ForCurrentProcess()->HasSwitch(
            switches::kSitePerProcess))) {
     // Reuse the current RFH if its SiteInstance matches the the navigation's
     // or if this is a subframe navigation. We only swap RFHs for subframes when
     // --site-per-process is enabled.
     CleanUpNavigation();
     navigation_rfh = render_frame_host_.get();
 
     // As SiteInstances are the same, check if the WebUI should be reused.
@@ skipping 1226 matching lines @@
 void RenderFrameHostManager::DeleteRenderFrameProxyHost(
     SiteInstance* instance) {
   RenderFrameProxyHostMap::iterator iter = proxy_hosts_.find(instance->GetId());
   if (iter != proxy_hosts_.end()) {
     delete iter->second;
     proxy_hosts_.erase(iter);
   }
 }
 
 }  // namespace content