Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 946543002: Update LocationLine without IO. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update LocationLine without IO. This enables to update location line even when IO is busy for other operation, e.g. directory rescan. BUG=460405 TEST=manually tested. Navigate to a directory and see how the UI changes. Committed: https://crrev.com/8c4c9c38c0caa2ab880b293c46d0429d99dd6d27 Cr-Commit-Position: refs/heads/master@{#317539}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -131 lines) Patch
M ui/file_manager/file_manager/background/js/volume_manager.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/common/js/util.js View 2 chunks +34 lines, -26 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/location_line.js View 5 chunks +103 lines, -103 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
yawano
PTAL. Thank you!
5 years, 10 months ago (2015-02-20 12:30:31 UTC) #2
fukino
lgtm. Thank you!
5 years, 10 months ago (2015-02-20 13:31:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946543002/1
5 years, 10 months ago (2015-02-23 01:25:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61438)
5 years, 10 months ago (2015-02-23 01:28:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946543002/20001
5 years, 10 months ago (2015-02-23 03:36:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-23 03:38:50 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 03:39:25 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c4c9c38c0caa2ab880b293c46d0429d99dd6d27
Cr-Commit-Position: refs/heads/master@{#317539}

Powered by Google App Engine
This is Rietveld 408576698