Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 946533003: Fix proxy from user policy on shared networks. (Closed)

Created:
5 years, 10 months ago by pneubeck (no reviews)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix proxy from user policy on shared networks. E.g. this happens for Ethernet (not the EAP configuration) which is always shared by all users. BUG=454966 Committed: https://crrev.com/6b24b2094c9e3bc35e2c30b368f292e078d4a00b Cr-Commit-Position: refs/heads/master@{#317315}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -20 lines) Patch
M chrome/browser/chromeos/proxy_config_service_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl_unittest.cc View 1 13 chunks +89 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pneubeck (no reviews)
ptal
5 years, 10 months ago (2015-02-20 13:03:28 UTC) #2
Andrew T Wilson (Slow)
lgtm https://codereview.chromium.org/946533003/diff/1/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc File chrome/browser/chromeos/proxy_config_service_impl_unittest.cc (right): https://codereview.chromium.org/946533003/diff/1/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc#newcode243 chrome/browser/chromeos/proxy_config_service_impl_unittest.cc:243: void SetUpProxyConfigService(bool with_profile_prefs) { Consider just passing in ...
5 years, 10 months ago (2015-02-20 13:38:58 UTC) #3
pneubeck (no reviews)
Thanks! https://codereview.chromium.org/946533003/diff/1/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc File chrome/browser/chromeos/proxy_config_service_impl_unittest.cc (right): https://codereview.chromium.org/946533003/diff/1/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc#newcode243 chrome/browser/chromeos/proxy_config_service_impl_unittest.cc:243: void SetUpProxyConfigService(bool with_profile_prefs) { On 2015/02/20 13:38:57, Andrew ...
5 years, 10 months ago (2015-02-20 13:51:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946533003/20001
5 years, 10 months ago (2015-02-20 13:53:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-20 14:16:46 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 14:17:26 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6b24b2094c9e3bc35e2c30b368f292e078d4a00b
Cr-Commit-Position: refs/heads/master@{#317315}

Powered by Google App Engine
This is Rietveld 408576698