Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 9465017: Make more of base compile with the Native Client toolchain. (Closed)

Created:
8 years, 10 months ago by bbudge
Modified:
8 years, 10 months ago
Reviewers:
brettw, jam
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Make more of base compile with the Native Client toolchain. This is needed to get parts of the PPAPI proxy to compile as untrusted code. Leaving base.gypi unchanged even though this adds files, as they are only used by experimental target. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123613

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
A base/os_compat_nacl.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
A base/os_compat_nacl.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
M base/shared_memory.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/third_party/nspr/prtime.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/threading/platform_thread_posix.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M base/time_posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bbudge
8 years, 10 months ago (2012-02-24 18:49:48 UTC) #1
jam
lgtm
8 years, 10 months ago (2012-02-24 21:27:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/9465017/6002
8 years, 10 months ago (2012-02-24 21:29:36 UTC) #3
commit-bot: I haz the power
Presubmit check for 9465017-6002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-24 21:29:40 UTC) #4
bbudge
need brettw for OWNERS
8 years, 10 months ago (2012-02-24 21:35:40 UTC) #5
brettw
lgtm
8 years, 10 months ago (2012-02-24 21:59:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/9465017/6002
8 years, 10 months ago (2012-02-24 22:57:45 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-02-25 00:56:16 UTC) #8
Change committed as 123613

Powered by Google App Engine
This is Rietveld 408576698