PDF: remove unused SkPDFDevice::setDCTEncoder()

src/pdf/SkPDFDevice.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkPDFDevice.h"
 
 #include "SkAnnotation.h"
@@ skipping 709 matching lines @@
 }
 
 // TODO(vandebo) change pageSize to SkSize.
 SkPDFDevice::SkPDFDevice(const SkISize& pageSize, const SkISize& contentSize,
                          const SkMatrix& initialTransform)
     : fPageSize(pageSize)
     , fContentSize(contentSize)
     , fLastContentEntry(NULL)
     , fLastMarginContentEntry(NULL)
     , fClipStack(NULL)
-    , fEncoder(NULL)

[mtklein, 2015/02/20 03:36:13]

So... this was just always NULL?

[hal.canary, 2015/02/20 12:52:57]

The constructor never sets it.  You had to call ->setDCTEncoder(), which in
practice no one ever did.  Then I landed http://crrev.com/935843007 , which took
away the possibility that they will in the future.

     , fRasterDpi(72.0f)
 {
     const SkImageInfo info = make_content_info(contentSize, &initialTransform);
 
     // Just report that PDF does not supports perspective in the
     // initial transform.
     NOT_IMPLEMENTED(initialTransform.hasPerspective(), true);
 
     // Skia generally uses the top left as the origin but PDF natively has the
     // origin at the bottom left. This matrix corrects for that.  But that only
@@ skipping 12 matching lines @@
 SkPDFDevice::SkPDFDevice(const SkISize& layerSize,
                          const SkClipStack& existingClipStack,
                          const SkRegion& existingClipRegion)
     : fPageSize(layerSize)
     , fContentSize(layerSize)
     , fExistingClipStack(existingClipStack)
     , fExistingClipRegion(existingClipRegion)
     , fLastContentEntry(NULL)
     , fLastMarginContentEntry(NULL)
     , fClipStack(NULL)
-    , fEncoder(NULL)
     , fRasterDpi(72.0f)
 {
     fInitialTransform.reset();
     fLegacyBitmap.setInfo(make_content_info(layerSize, NULL));
 
     this->init();
 }
 
 SkPDFDevice::~SkPDFDevice() {
     this->cleanUp(true);
@@ skipping 1397 matching lines @@
         shape.addRect(SkRect::MakeWH(SkIntToScalar(subset.width()),
                                      SkIntToScalar( subset.height())));
         shape.transform(matrix);
         content.setShape(shape);
     }
     if (!content.needSource()) {
         return;
     }
 
     SkAutoTUnref<SkPDFObject> image(
-            SkPDFCreateImageObject(*bitmap, subset, fEncoder));
+            SkPDFCreateImageObject(*bitmap, subset));
     if (!image) {
         return;
     }
 
     SkPDFUtils::DrawFormXObject(this->addXObjectResource(image.get()),
                                 &content.entry()->fContent);
 }