Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Issue 946483002: [Oilpan] Change a test behavior (Closed)

Created:
5 years, 10 months ago by peria
Modified:
5 years, 10 months ago
CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Change the behavior of HeapTest.TraceDeepEagerly. Before this change, this test fails if GC uses a large stack memory to recursive trace. This CL 1) makes recursive tracing deeper, to ensure lazy tracing occurs. 2) avoids recursive trace if lazy trace has been called, to finish tests quickly. BUG=420515, 457982 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190586

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Source/platform/heap/HeapTest.cpp View 2 chunks +3 lines, -2 lines 2 comments Download

Messages

Total messages: 11 (4 generated)
peria
PTL
5 years, 10 months ago (2015-02-20 05:19:51 UTC) #2
sof
lgtm
5 years, 10 months ago (2015-02-20 11:01:45 UTC) #4
kouhei (in TOK)
lgtm
5 years, 10 months ago (2015-02-20 12:24:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946483002/1
5 years, 10 months ago (2015-02-20 16:46:12 UTC) #7
haraken
LGTM https://codereview.chromium.org/946483002/diff/1/Source/platform/heap/HeapTest.cpp File Source/platform/heap/HeapTest.cpp (right): https://codereview.chromium.org/946483002/diff/1/Source/platform/heap/HeapTest.cpp#newcode5462 Source/platform/heap/HeapTest.cpp:5462: if (sTraceLazy <= 2) Can we add a ...
5 years, 10 months ago (2015-02-20 20:15:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190586
5 years, 10 months ago (2015-02-20 22:10:35 UTC) #10
peria
5 years, 10 months ago (2015-02-23 02:42:09 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/946483002/diff/1/Source/platform/heap/HeapTes...
File Source/platform/heap/HeapTest.cpp (right):

https://codereview.chromium.org/946483002/diff/1/Source/platform/heap/HeapTes...
Source/platform/heap/HeapTest.cpp:5462: if (sTraceLazy <= 2)
On 2015/02/20 20:15:31, haraken wrote:
> 
> Can we add a comment on this?

This patch has been committed, so I'll do it in another patch.

Powered by Google App Engine
This is Rietveld 408576698