Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

Issue 946473002: Move base_dir to user_story_set, remove file_path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
diff --git a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
index 7d89b98b138570ae3b51797084345e36043efd51..16366bbce80428409efa1e5caa45e79e9af5f304 100644
--- a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
+++ b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
@@ -86,10 +86,10 @@ class PageSetSmokeTest(unittest.TestCase):
page, page_set.file_path)))
def CheckAttributesOfPageSetBasicAttributes(self, page_set):
- if page_set.file_path is not None:
+ if page_set.base_dir is not None:
self.assertTrue(
- isinstance(page_set.file_path, str),
- msg='page_set %\'s file_path must have type string')
+ isinstance(page_set.base_dir, str),
+ msg='page_set %\'s base_dir must have type string')
self.assertTrue(
isinstance(page_set.archive_data_file, str),
« no previous file with comments | « tools/telemetry/telemetry/page/page_unittest.py ('k') | tools/telemetry/telemetry/user_story/user_story_set.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698