Source/core/animation/CompositorAnimations.h - Issue 946323002: Animations: Introduce compositor AnimationPlayer and AnimationTimeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/CompositorAnimations.h

Issue 946323002: Animations: Introduce compositor AnimationPlayer and AnimationTimeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix the order. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/AnimationPlayer.cpp ('K') | « Source/core/animation/AnimationTimeline.cpp ('k') | Source/core/animation/CompositorAnimations.cpp » ('j') | Source/platform/RuntimeEnabledFeatures.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/CompositorAnimations.h

diff --git a/Source/core/animation/CompositorAnimations.h b/Source/core/animation/CompositorAnimations.h

index 60523e0de9cefb912854caabaef861e59a43e137..9b4431c7a6d775aded0f176f3a5e9495e8affc28 100644

--- a/Source/core/animation/CompositorAnimations.h

+++ b/Source/core/animation/CompositorAnimations.h

@@ -54,8 +54,8 @@ public:

virtual bool canStartAnimationOnCompositor(const Element&);

// FIXME: This should return void. We should know ahead of time whether these animations can be started.

virtual bool startAnimationOnCompositor(const Element&, int group, double startTime, double timeOffset, const Timing&, const AnimationPlayer*, const AnimationEffect&, Vector<int>& startedAnimationIds, double playerPlaybackRate);

- virtual void cancelAnimationOnCompositor(const Element&, int id);

- virtual void pauseAnimationForTestingOnCompositor(const Element&, int id, double pauseTime);

+ virtual void cancelAnimationOnCompositor(const Element&, const AnimationPlayer*, int id);

+ virtual void pauseAnimationForTestingOnCompositor(const Element&, const AnimationPlayer*, int id, double pauseTime);

dstockwell 2015/03/16 00:11:27 can't this be const AnimationPlayer& ?

loyso (OOO) 2015/03/18 06:59:43 Done.

virtual bool getAnimatedBoundingBox(FloatBox&, const AnimationEffect&, double minValue, double maxValue) const;

protected: