Animations: Introduce compositor AnimationPlayer and AnimationTimeline.

Source/core/animation/AnimationPlayer.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 21 matching lines @@
 #define AnimationPlayer_h
 
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseProperty.h"
 #include "core/CSSPropertyNames.h"
 #include "core/animation/AnimationNode.h"
 #include "core/dom/ActiveDOMObject.h"
 #include "core/dom/DOMException.h"
 #include "core/events/EventTarget.h"
 #include "platform/heap/Handle.h"
+#include "public/platform/WebCompositorAnimationDelegate.h"
+#include "public/platform/WebCompositorAnimationPlayerClient.h"
 #include "wtf/RefPtr.h"
 
 namespace blink {
 
 class AnimationTimeline;
 class Element;
 class ExceptionState;
+class WebCompositorAnimationPlayer;
 
 class AnimationPlayer final
-    : public EventTargetWithInlineData
-    , public RefCountedWillBeNoBase<AnimationPlayer>
-    , public ActiveDOMObject {
+    : public EventTargetWithInlineData,
+    public RefCountedWillBeNoBase<AnimationPlayer>,
+    public ActiveDOMObject,
+    public WebCompositorAnimationDelegate,
+    public WebCompositorAnimationPlayerClient {
     DEFINE_WRAPPERTYPEINFO();
     REFCOUNTED_EVENT_TARGET(AnimationPlayer);
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(AnimationPlayer);
 public:
     enum AnimationPlayState {
         Idle,
         Pending,
         Running,
         Paused,
         Finished
@@ skipping 79 matching lines @@
     bool maybeStartAnimationOnCompositor();
     void cancelAnimationOnCompositor();
     void cancelIncompatibleAnimationsOnCompositor();
     bool hasActiveAnimationsOnCompositor();
     void setCompositorPending(bool sourceChanged = false);
     void notifyCompositorStartTime(double timelineTime);
     void notifyStartTime(double timelineTime);
 
     bool affects(const Element&, CSSPropertyID) const;
 
+    // WebCompositorAnimationDelegate implementation.
+    void notifyAnimationStarted(double monotonicTime, int group) override;
+    void notifyAnimationFinished(double monotonicTime, int group) override;

[dstockwell, 2015/02/26 00:07:12]

Is this just for consistency? Do we need it?

[loyso (OOO), 2015/02/26 03:24:57]

That's already existing interface with pure abstract function. We must override
it :(

+
+    void createCompositorPlayer();

[dstockwell, 2015/02/26 00:07:12]

These should probably not be public.

[loyso (OOO), 2015/02/26 03:24:57]

Sure! This is a side-effect of the draft version.

+    void destroyCompositorPlayer();
+    // WebCompositorAnimationPlayerClient implementation.
+    WebCompositorAnimationPlayer* compositorPlayer() const override { return m_compositorPlayer.get(); }
+
     void preCommit(int compositorGroup, bool startOnCompositor);
     void postCommit(double timelineTime);
 
     unsigned sequenceNumber() const { return m_sequenceNumber; }
     int compositorGroup() const { return m_compositorGroup; }
 
     static bool hasLowerPriority(const AnimationPlayer* player1, const AnimationPlayer* player2)
     {
         return player1->sequenceNumber() < player2->sequenceNumber();
     }
@@ skipping 92 matching lines @@
         CompositorPendingChange m_compositorPendingChange;
     };
 
     // This mirrors the known compositor state. It is created when a compositor
     // animation is started. Updated once the start time is known and each time
     // modifications are pushed to the compositor.
     OwnPtr<CompositorState> m_compositorState;
     bool m_compositorPending;
     int m_compositorGroup;
 
+    OwnPtr<WebCompositorAnimationPlayer> m_compositorPlayer;
+
     bool m_currentTimePending;
     bool m_stateIsBeingUpdated;
 
 };
 
 } // namespace blink
 
 #endif // AnimationPlayer_h