Source/bindings/core/v8/V8Binding.cpp - Issue 946293003: [bindings] Assert toDoubleSlow on v8::Value being a number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8Binding.cpp

Issue 946293003: [bindings] Assert toDoubleSlow on v8::Value being a number. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8Binding.cpp

diff --git a/Source/bindings/core/v8/V8Binding.cpp b/Source/bindings/core/v8/V8Binding.cpp

index fd48a502ada3ea0db78f4fb100a94108dd3550de..60b424867a3cf167d4fac76995dc59441b8a7bc9 100644

--- a/Source/bindings/core/v8/V8Binding.cpp

+++ b/Source/bindings/core/v8/V8Binding.cpp

@@ -533,6 +533,7 @@ float toRestrictedFloat(v8::Handle<v8::Value> value, ExceptionState& exceptionSt

double toDoubleSlow(v8::Handle<v8::Value> value, ExceptionState& exceptionState)

{

+ ASSERT(!value->IsNumber());

v8::Isolate* isolate = v8::Isolate::GetCurrent();

v8::TryCatch block(isolate);

double doubleValue = value->NumberValue();

« no previous file with comments | « no previous file | no next file » | no next file with comments »