Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 946293002: Correctly whitelist the PDF plugin in the PDF extension. (Closed)

Created:
5 years, 10 months ago by Sam McNally
Modified:
5 years, 10 months ago
Reviewers:
Bernhard Bauer, raymes
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, markusheintz_, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly whitelist the PDF plugin in the PDF extension. For plugins listed in chrome/browser/resources/plugin_metadata/plugins_*.json, the resource identifier for that plugin becomes the key used in those JSON files. Previously, the PDF plugin filename was used as the resource identifier to whitelist the PDF plugin within the PDF extension. This caused the whitelisting to be ineffective for official builds and also other builds after r316957 added an entry for the Chromium PDF Viewer plugin. This CL fixes this by using the keys from the plugin metadata files as the resource identifiers for whitelisting the PDF plugin. BUG=459998 Committed: https://crrev.com/2c8ef923fc3a440aa99b09372fde8f3d0893f551 Cr-Commit-Position: refs/heads/master@{#317556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/content_settings/content_settings_internal_extension_provider.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/pdf/pdf_extension_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/pdf/pdf_extension_util.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sam McNally
+bauerb for chrome/browser/content_settings/content_settings_internal_extension_provider.cc +raymes for chrome/browser/pdf
5 years, 10 months ago (2015-02-23 00:07:40 UTC) #2
raymes
lgtm
5 years, 10 months ago (2015-02-23 00:11:18 UTC) #3
Bernhard Bauer
lgtm
5 years, 10 months ago (2015-02-23 10:01:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946293002/1
5 years, 10 months ago (2015-02-23 10:03:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 10:13:50 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 10:14:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c8ef923fc3a440aa99b09372fde8f3d0893f551
Cr-Commit-Position: refs/heads/master@{#317556}

Powered by Google App Engine
This is Rietveld 408576698