Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 946283003: [linux] Use _GLIBCXX_DEBUG in Debug builds by default for better checking. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[linux] Use _GLIBCXX_DEBUG in Debug builds by default for better checking. The _GLIBCXX_DEBUG macro is now set by default for Linux Debug builds and can be disabled using the disable_glibcxx_debug=1 setting (compatible with Chrome). This will help us catch problems earlier. BUG=v8:3638 LOG=n Committed: https://crrev.com/b9513848873ef579e2023bdd728df27443fba55f Cr-Commit-Position: refs/heads/master@{#26790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M build/standalone.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M build/toolchain.gypi View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-23 06:04:40 UTC) #2
Jarin
lgtm
5 years, 10 months ago (2015-02-23 06:11:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946283003/1
5 years, 10 months ago (2015-02-23 06:12:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 06:13:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 06:13:52 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 06:14:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9513848873ef579e2023bdd728df27443fba55f
Cr-Commit-Position: refs/heads/master@{#26790}

Powered by Google App Engine
This is Rietveld 408576698