Added isSyncingUrlsWithKeystorePassphrase.

Added isSyncingUrlsWithKeystorePassphrase.

This determines if sync is initialized and syncing URLs with the
appropriate keystore passphrase type to support contextual searches.

BUG=460786
Committed: https://crrev.com/a68bc5fc4270c417e758a5b5b4e094b1d8b97c1c
Cr-Commit-Position: refs/heads/master@{#317610}

[Joao da Silva, 2015-02-22 19:33:13]

joaodasilva@chromium.org changed reviewers:
+ mariakhomenko@chromium.org, nyquist@chromium.org

[Joao da Silva, 2015-02-22 19:33:13]

Maria, PTAL at this one too.

Tommy for owner approval.

This method is being upstreamed and is used at
https://chrome-internal-review.googlesource.com/#/c/200676.

[nyquist, 2015-02-23 17:02:55]

nyquist@chromium.org changed reviewers:
+ zea@chromium.org

[nyquist, 2015-02-23 17:02:55]

lgtm, but adding zea@ to verify that this is what you want to do.

zea: Please see bug and/or downstream CL for context.

https://codereview.chromium.org/946273002/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
(right):

https://codereview.chromium.org/946273002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java:545:
public boolean isSyncingUrlsWithKeystorePassphrase() {
Nit: Add a comment?
@return whether foo bar baz

[Nicolas Zea, 2015-02-23 17:09:36]

Looks correct to me. That said, we could theoretically be storing the encryption
state in a preference as well, so that it's known and accessible without sync
needing to be initialized (it does mean having two copies of that state though,
but that I think is something we might need soon anyways).

Is that something that you want here?

[nyquist, 2015-02-23 17:14:06]

From what I can tell, I don't think that's necessary here. However, I might be
wrong. I'll leave it up to Joao to decide.

[Joao da Silva, 2015-02-23 17:21:15]

New patchsets have been uploaded after l-g-t-m from nyquist@chromium.org

[Joao da Silva, 2015-02-23 17:22:29]

I've experimented with this and sync does come up early enough for contextual
voice searches.

If the startup time remains an issue then we'll explore the option of caching
the sync state in a pref.

Thanks for the review!

https://codereview.chromium.org/946273002/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
(right):

https://codereview.chromium.org/946273002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java:545:
public boolean isSyncingUrlsWithKeystorePassphrase() {
On 2015/02/23 17:02:55, nyquist wrote:
> Nit: Add a comment?
> @return whether foo bar baz

Done.

[Joao da Silva, 2015-02-23 17:22:32]

The CQ bit was checked by joaodasilva@chromium.org

[commit-bot: I haz the power, 2015-02-23 17:23:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/946273002/20001

[commit-bot: I haz the power, 2015-02-23 17:25:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 17:25:45]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Joao da Silva, 2015-02-23 18:18:43]

The CQ bit was checked by joaodasilva@chromium.org

[commit-bot: I haz the power, 2015-02-23 18:19:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/946273002/20001

[commit-bot: I haz the power, 2015-02-23 18:29:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-23 18:29:59]

Patchset 2 (id:??) landed as
https://crrev.com/a68bc5fc4270c417e758a5b5b4e094b1d8b97c1c
Cr-Commit-Position: refs/heads/master@{#317610}