Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 946243003: Remove unused MediaControlElementType enum values (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 10 months ago
Reviewers:
fs
CC:
blink-reviews, nektarios, blink-reviews-rendering, nessy, je_julie(Not used), aboxhall, zoltan1, eae+blinkwatch, philipj_slow, gasubic, fs, eric.carlson_apple.com, leviw+renderwatch, Dominik Röttsches, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, jchaffraix+rendering, pdr+renderingwatchlist_chromium.org, vcarbune.chromium, dmazzoni
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unused MediaControlElementType enum values MediaStatusDisplay and MediaTextTrackDisplay, that is. BUG=448795 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M Source/core/html/shadow/MediaControlElementTypes.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutMediaControls.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/accessibility/AXMediaControls.cpp View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
philipj_slow
PTAL
5 years, 10 months ago (2015-02-23 07:09:20 UTC) #1
fs
lgtm
5 years, 10 months ago (2015-02-23 09:44:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946243003/1
5 years, 10 months ago (2015-02-23 09:49:11 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 09:51:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190644

Powered by Google App Engine
This is Rietveld 408576698