Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: base/BUILD.gn

Issue 946183002: Add base_unittests to win8 trybot. Fix PEImage tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix expectations Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base.gyp » ('j') | base/win/pe_image_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 045878c555f1052fd3f29d7b4e86dd8561b2916b..7e1d5feef594adcf2d94ca26626af321e7557002 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1135,6 +1135,23 @@ source_set("protect_file_posix") {
]
}
+if (is_win) {
+ shared_library("pe_image_test") {
+ sources = [
+ "win/pe_image_test.cc",
+ ]
+ ldflags = [
+ "/DELAYLOAD:cfgmgr32.dll",
+ "/DELAYLOAD:shell32.dll",
+ "/SUBSYSTEM:WINDOWS",
+ ]
+ libs = [
+ "cfgmgr32.lib",
+ "shell32.lib",
+ ]
+ }
+}
+
test("base_unittests") {
sources = [
"android/application_status_listener_unittest.cc",
@@ -1374,6 +1391,7 @@ test("base_unittests") {
":base",
":i18n",
":message_loop_tests",
+ ":pe_image_test",
rvargas (doing something else) 2015/02/24 20:03:22 This is a win specific dep so I think it'll break
Will Harris 2015/02/24 20:46:54 Done.
":prefs",
":prefs_test_support",
"//base/allocator",
« no previous file with comments | « no previous file | base/base.gyp » ('j') | base/win/pe_image_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698