Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: base/base.gyp

Issue 946183002: Add base_unittests to win8 trybot. Fix PEImage tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: expectation logic fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base_unittests.isolate » ('j') | base/files/file_enumerator_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index 8cd5d6aef55949464de7cf3061637a8fc1d7fcbb..771364d578a643abfc3eb47f194aaf9777b841de 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -768,6 +768,9 @@
'message_loop/message_pump_libevent_unittest.cc',
'threading/worker_pool_posix_unittest.cc',
],
+ 'dependencies': [
+ 'pe_image_test',
+ ],
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
'msvs_disabled_warnings': [
4267,
@@ -1536,6 +1539,21 @@
},
},
},
+ {
+ 'target_name': 'pe_image_test',
rvargas (doing something else) 2015/02/24 01:52:20 build.gn?
Will Harris 2015/02/24 19:00:28 Done.
+ 'type': 'shared_library',
+ 'sources': [
+ 'win/pe_image_test.cc',
+ ],
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'SubSystem': '2', # Set /SUBSYSTEM:WINDOWS
+ 'DelayLoadDLLs': [
+ 'user32.dll',
+ ],
+ },
+ },
+ },
],
}],
['test_isolation_mode != "noop"', {
« no previous file with comments | « no previous file | base/base_unittests.isolate » ('j') | base/files/file_enumerator_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698