base/win/pe_image_test.cc - Issue 946183002: Add base_unittests to win8 trybot. Fix PEImage tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/win/pe_image_test.cc

Issue 946183002: Add base_unittests to win8 trybot. Fix PEImage tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: expectation logic fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
	rvargas (doing something else) 2015/02/24 01:52:20 no (c) on new files no (c) on new files Will Harris 2015/02/24 19:00:28 Done. Show quoted text On 2015/02/24 01:52:20, rvargas wrote: > no (c) on new files Done.
2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ipc/ipc_message_attachment.h"	5 #include <windows.h>

6	6

7 namespace IPC {	7 extern "C" {

8	8

9 MessageAttachment::MessageAttachment() {	9 __declspec(dllexport) void export_func() {
	rvargas (doing something else) 2015/02/24 01:52:20 CamelCase for functions? CamelCase for functions? Will Harris 2015/02/24 19:00:28 Done. Show quoted text On 2015/02/24 01:52:20, rvargas wrote: > CamelCase for functions? Done.
	10 HWND dummy = GetDesktopWindow();

	11 SetWindowTextA(dummy, "dummy");

10 }	12 }

11

12 MessageAttachment::~MessageAttachment() {

13 }	13 }

14

15 } // namespace IPC

OLD	NEW

« base/files/file_enumerator_win.cc ('K') | « base/files/file_enumerator_win.cc ('k') | base/win/pe_image_unittest.cc » ('j') | base/win/pe_image_unittest.cc » ('J')