Make PointerDeviceObserver use ui::InputDeviceEventObserver on X11

Make PointerDeviceObserver use ui::InputDeviceEventObserver on X11

This CL:
- Makes PointerDeviceObserver use ui::InputDeviceEventObserver on X11 (it is
  already used on Ozone)
- Makes X11HotplugEventObserver notify ui::DeviceDataManager when a mouse /
  touchpad is plugged in / unplugged
- Removes DeviceHierarchyObserver

BUG=440503
TEST=Manual

Committed: https://crrev.com/6f440efc09d6b7181cdafe9519117609a281fdd2
Cr-Commit-Position: refs/heads/master@{#318997}

[pkotwicz, 2015-02-22 00:03:00]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2015-02-22 00:07:15]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2015-02-22 00:19:10]

Patchset #1 (id:40001) has been deleted

[pkotwicz, 2015-02-22 00:22:55]

Patchset #1 (id:60001) has been deleted

[pkotwicz, 2015-02-22 00:38:35]

pkotwicz@chromium.org changed reviewers:
+ sadrul@chromium.org

[pkotwicz, 2015-02-22 00:38:35]

Sadrul, PTAL.
I tried checking the ValuatorClassInfo to determine whether a device is a mouse,
but this does not seem to be possible on ChromeOS. ChromeOS seems to set the
same valuators (but with different values) for all pointer devices. So it is not
possible to determine whether a mouse is attached by checking for the presence
of the valuators with labels "Rel X" and "Rel Y"

This CL depends on https://codereview.chromium.org/945983002/

[sadrul, 2015-02-23 21:54:04]

https://codereview.chromium.org/946173002/diff/80001/chrome/browser/chromeos/...
File chrome/browser/chromeos/events/xinput_hierarchy_changed_event_listener.cc
(right):

https://codereview.chromium.org/946173002/diff/80001/chrome/browser/chromeos/...
chrome/browser/chromeos/events/xinput_hierarchy_changed_event_listener.cc:39: }
out of curiosity: what does this do? Is there non-x11 equivalent to this for
ozone? Can this also be implemented in terms of InputDeviceEventObserver?

https://codereview.chromium.org/946173002/diff/80001/ui/events/platform/x11/x...
File ui/events/platform/x11/x11_hotplug_event_handler.cc (right):

https://codereview.chromium.org/946173002/diff/80001/ui/events/platform/x11/x...
ui/events/platform/x11/x11_hotplug_event_handler.cc:433: DeviceInfo(device,
device_type, GetDevicePath(display, device)));
Can we do some filtering here to avoid the same filtering for all
device-classes? (e.g. there's no use creating a DeviceInfo with enabled = false,
or for test-devices)

[pkotwicz, 2015-02-24 23:33:33]

Patchset #2 (id:100001) has been deleted

[pkotwicz, 2015-02-24 23:50:27]

Sadrul, can you please take another look?

https://codereview.chromium.org/946173002/diff/80001/chrome/browser/chromeos/...
File chrome/browser/chromeos/events/xinput_hierarchy_changed_event_listener.cc
(right):

https://codereview.chromium.org/946173002/diff/80001/chrome/browser/chromeos/...
chrome/browser/chromeos/events/xinput_hierarchy_changed_event_listener.cc:39: }
This was added in https://codereview.chromium.org/6975057 There is no ozone
equivalent that a know of. I have checked and the bug fixed by this file does
not exist on ozone.

Yes this could be implemented via InputDeviceEventObserver. I don't care to do
so because this file will disappear once ChromeOS stops using X11.

[pkotwicz, 2015-02-26 19:26:15]

sadrul, Ping?

[sadrul, 2015-02-26 22:49:53]

On 2015/02/26 19:26:15, pkotwicz wrote:
> sadrul, Ping?

Missed this, sorry. I will review later tonight.

[sadrul, 2015-03-02 16:51:27]

LGTM

(if you land parts of the CL in another CL, please make sure to merge the CL
with ToT before pinging for review)

https://codereview.chromium.org/946173002/diff/140001/ui/events/devices/input...
File ui/events/devices/input_device_event_observer.h (right):

https://codereview.chromium.org/946173002/diff/140001/ui/events/devices/input...
ui/events/devices/input_device_event_observer.h:24: };
These changes have already landed in a separate CL, right?

[pkotwicz, 2015-03-02 18:26:00]

I will try to be less careless in the future (and will also try to run try bots
before asking for review)

[pkotwicz, 2015-03-02 19:18:13]

Patchset #4 (id:160001) has been deleted

[pkotwicz, 2015-03-02 19:20:24]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-03-02 19:20:24]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/946173002/#ps180001
(title: " ")

[commit-bot: I haz the power, 2015-03-02 19:21:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/946173002/180001

[commit-bot: I haz the power, 2015-03-02 19:56:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-02 19:57:00]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pkotwicz, 2015-03-02 20:23:44]

pkotwicz@chromium.org changed reviewers:
+ oshima@chromium.org

[pkotwicz, 2015-03-02 20:23:44]

Oshima for chrome/browser/chromeos OWNERS

[oshima, 2015-03-03 23:12:26]

lgtm

[pkotwicz, 2015-03-03 23:19:00]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-03-03 23:19:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/946173002/180001

[commit-bot: I haz the power, 2015-03-04 02:12:22]

Committed patchset #4 (id:180001)

[commit-bot: I haz the power, 2015-03-04 02:13:22]

Patchset 4 (id:??) landed as
https://crrev.com/6f440efc09d6b7181cdafe9519117609a281fdd2
Cr-Commit-Position: refs/heads/master@{#318997}