Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 946103004: Add ScopedAllowWait to TaskGraphRunner to Avoid Crash in Shutdown (Closed)

Created:
5 years, 10 months ago by weiliangc
Modified:
5 years, 10 months ago
Reviewers:
danakj, brettw, jam
CC:
chromium-reviews, cc-bugs_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dirtyRSLL
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ScopedAllowWait to TaskGraphRunner to Avoid Crash in Shutdown When shutting down, TaskGraphRunner will clear out tasks that are ready to run and wait for running tasks to finish running. Wait is disallowed in main thread and crashes in single thread impl-side painting. R=danakj, jam, brettw BUG=369653 Committed: https://crrev.com/0471c66927ca0c21a0785174ef3fe245b9908766 Cr-Commit-Position: refs/heads/master@{#318265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/threading/thread_restrictions.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/resources/task_graph_runner.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
weiliangc
This CL adds friend class to base::ThreadRestrictions, thus require review from jam and/or brettw. Reasoning ...
5 years, 10 months ago (2015-02-25 21:47:04 UTC) #1
jam
lgtm
5 years, 10 months ago (2015-02-26 05:51:10 UTC) #2
danakj
LGTM
5 years, 10 months ago (2015-02-26 17:30:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946103004/1
5 years, 10 months ago (2015-02-26 17:31:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 18:33:20 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 18:33:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0471c66927ca0c21a0785174ef3fe245b9908766
Cr-Commit-Position: refs/heads/master@{#318265}

Powered by Google App Engine
This is Rietveld 408576698