Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 946083003: Rename Sky's custom2 to custom (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
ojan
CC:
ojan, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename Sky's custom2 to custom We've removed the old implementation of custom elements. We can move the new implementation into the proper place and give the classes their proper name. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ffb08ca89690579f431f35c8d84efccf0276a929

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -337 lines) Patch
M sky/engine/bindings/scripts/templates/attributes_cpp.template View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/scripts/templates/methods_cpp.template View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/scripts/v8_attributes.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/scripts/v8_methods.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/build/scripts/templates/ElementFactory.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/core.gni View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/engine/core/dom/Document.h View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/DocumentInit.h View 3 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/dom/DocumentInit.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
A + sky/engine/core/dom/custom/custom_element.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/engine/core/dom/custom/custom_element.cc View 4 chunks +7 lines, -7 lines 0 comments Download
A + sky/engine/core/dom/custom/custom_element_callback_scope.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + sky/engine/core/dom/custom/custom_element_callback_scope.cc View 2 chunks +6 lines, -6 lines 0 comments Download
A + sky/engine/core/dom/custom/custom_element_registry.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + sky/engine/core/dom/custom/custom_element_registry.cc View 2 chunks +5 lines, -5 lines 0 comments Download
D sky/engine/core/dom/custom2/new_custom_element.h View 1 chunk +0 lines, -26 lines 0 comments Download
D sky/engine/core/dom/custom2/new_custom_element.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D sky/engine/core/dom/custom2/new_custom_element_callback_scope.h View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/engine/core/dom/custom2/new_custom_element_callback_scope.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/engine/core/dom/custom2/new_custom_element_registry.h View 1 chunk +0 lines, -46 lines 0 comments Download
D sky/engine/core/dom/custom2/new_custom_element_registry.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M sky/engine/web/WebElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-02-21 01:16:47 UTC) #1
ojan
lgtm
5 years, 10 months ago (2015-02-21 01:35:11 UTC) #2
abarth-chromium
5 years, 10 months ago (2015-02-21 01:35:52 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ffb08ca89690579f431f35c8d84efccf0276a929 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698