Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2305)

Unified Diff: tools/gn/header_checker.h

Issue 946043002: GN header checker enhancements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@check3
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/header_checker.cc » ('j') | tools/gn/header_checker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/header_checker.h
diff --git a/tools/gn/header_checker.h b/tools/gn/header_checker.h
index e024c02a2cd60b386e5ee167b7bc0edc5a80efb0..35e8887313e60a5b3520ce6b4179daff86915630 100644
--- a/tools/gn/header_checker.h
+++ b/tools/gn/header_checker.h
@@ -148,6 +148,14 @@ class HeaderChecker : public base::RefCountedThreadSafe<HeaderChecker> {
bool require_permitted,
Chain* chain) const;
+ // Makes a very descriptive error message for when an include is disallowed
+ // from a given from_target, with a missing dependency to one of the given
+ // targets.
+ static Err MakeUnreachableError(const InputFile& source_file,
+ const LocationRange& range,
+ const Target* from_target,
+ const TargetVector& targets);
+
// Non-locked variables ------------------------------------------------------
//
// These are initialized during construction (which happens on one thread)
« no previous file with comments | « no previous file | tools/gn/header_checker.cc » ('j') | tools/gn/header_checker.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698