Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 946023002: Update GN build files with the cpu_arch -> current_cpu change. (Closed)

Created:
5 years, 10 months ago by Dirk Pranke
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update GN build files with the cpu_arch -> current_cpu change. R=machenbach@chromium.org, jochen@chromium.org BUG=crbug.com/344767 LOG=Y Committed: https://crrev.com/f8abac93311b441d241fbf4898ea106e84bcffac Cr-Commit-Position: refs/heads/master@{#26804}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 14 (4 generated)
Dirk Pranke
5 years, 10 months ago (2015-02-20 20:57:10 UTC) #2
Michael Achenbach
lgtm
5 years, 10 months ago (2015-02-21 21:07:09 UTC) #3
jochen (gone - plz use gerrit)
https://codereview.chromium.org/946023002/diff/20001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/946023002/diff/20001/BUILD.gn#newcode21 BUILD.gn:21: v8_target_arch = current_cpu is current_cpu always the target arch? ...
5 years, 10 months ago (2015-02-23 07:49:19 UTC) #4
Dirk Pranke
https://codereview.chromium.org/946023002/diff/20001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/946023002/diff/20001/BUILD.gn#newcode21 BUILD.gn:21: v8_target_arch = current_cpu On 2015/02/23 07:49:19, jochen (slow) wrote: ...
5 years, 10 months ago (2015-02-23 18:58:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946023002/20001
5 years, 10 months ago (2015-02-23 20:22:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/761)
5 years, 10 months ago (2015-02-23 20:27:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946023002/20001
5 years, 10 months ago (2015-02-23 20:30:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-23 21:01:37 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-23 21:01:39 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 21:01:48 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f8abac93311b441d241fbf4898ea106e84bcffac
Cr-Commit-Position: refs/heads/master@{#26804}

Powered by Google App Engine
This is Rietveld 408576698