Issue 945953002: Subzero: Translate the unreachable bitcode directly to ud2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 945953002: Subzero: Translate the unreachable bitcode directly to ud2. (Closed)

Created:
5 years, 10 months ago by Jim Stichnoth

Modified:
5 years, 10 months ago

Reviewers:
jvoung (off chromium), Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Translate the unreachable bitcode directly to ud2. This removes ice_unreachable() from the Subzero runtime. The ice_unreachable() implementation is problematic since it makes a call to external function abort(), which leads to an undefined symbol error in the linker because abort() is internalized at link time. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4091 R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c53f7a6ae8ee71c352e1546680431818f9fdd51b

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -7 lines)			Patch
M	runtime/szrt.c	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/IceTargetLoweringX8632.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/unreachable.ll	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

5 years, 10 months ago (2015-02-20 19:43:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c53f7a6ae8ee71c352e1546680431818f9fdd51b (presubmit successful).