Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 945933003: Add support for log file rotation. (Closed)

Created:
5 years, 10 months ago by Steve McKay
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for log file rotation. Clean up error logging (more consistent formatting). Log stack traces. Ensure most substantial Promise chains used in importer code have catch clause hooked up to logger. BUG=460614 BUG=449034 TEST=browser_test: FileManagerJsTest.* Committed: https://crrev.com/4b600b552c6a611827539237270ce3f5eea17999 Cr-Commit-Position: refs/heads/master@{#317547}

Patch Set 1 #

Patch Set 2 : Add support for rotating logs. #

Patch Set 3 : Simplify rotation logic. Delete the next log if it exists at time of rotation. #

Total comments: 2

Patch Set 4 : Respond to review comments. #

Patch Set 5 : Merge w/ master. #

Messages

Total messages: 20 (7 generated)
Steve McKay
5 years, 10 months ago (2015-02-20 22:57:44 UTC) #2
Steve McKay
Simplify rotation logic. Delete the next log if it exists at time of rotation.
5 years, 10 months ago (2015-02-21 17:46:38 UTC) #3
fukino
Thank you! lgtm wit a nit :) https://codereview.chromium.org/945933003/diff/40001/ui/file_manager/file_manager/common/js/importer_common.js File ui/file_manager/file_manager/common/js/importer_common.js (right): https://codereview.chromium.org/945933003/diff/40001/ui/file_manager/file_manager/common/js/importer_common.js#newcode785 ui/file_manager/file_manager/common/js/importer_common.js:785: * This ...
5 years, 10 months ago (2015-02-23 03:42:26 UTC) #4
Steve McKay
Respond to review comments.
5 years, 10 months ago (2015-02-23 03:47:31 UTC) #6
Steve McKay
Dones. Thanks! https://codereview.chromium.org/945933003/diff/40001/ui/file_manager/file_manager/common/js/importer_common.js File ui/file_manager/file_manager/common/js/importer_common.js (right): https://codereview.chromium.org/945933003/diff/40001/ui/file_manager/file_manager/common/js/importer_common.js#newcode785 ui/file_manager/file_manager/common/js/importer_common.js:785: * This function must be run befor ...
5 years, 10 months ago (2015-02-23 03:50:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945933003/60001
5 years, 10 months ago (2015-02-23 03:51:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61456)
5 years, 10 months ago (2015-02-23 03:53:45 UTC) #11
Steve McKay
Merge w/ master.
5 years, 10 months ago (2015-02-23 04:19:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945933003/80001
5 years, 10 months ago (2015-02-23 04:20:17 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61468)
5 years, 10 months ago (2015-02-23 04:22:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945933003/80001
5 years, 10 months ago (2015-02-23 05:33:34 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-23 05:46:27 UTC) #19
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 05:47:11 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/4b600b552c6a611827539237270ce3f5eea17999
Cr-Commit-Position: refs/heads/master@{#317547}

Powered by Google App Engine
This is Rietveld 408576698