Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 945923002: Fix memory leak and crash when parsing baked-in configs in domain reliability monitor. (Closed)

Created:
5 years, 10 months ago by grt (UTC plus 2)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, Sigurður Ásgeirsson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix memory leak and crash when parsing baked-in configs in domain reliability monitor. Invalid baked-in configs would be leaked (in FromJSON) and then crash due to a null deref (in AddContext). This change also makes two minor improvements: - pass scoped_refptrs by const ref - use a StringPiece rather than a std::string when parsing bake-in configs BUG=460483 R=ttuttle@chromium.org Committed: https://crrev.com/2792ed71482cd849ebf312fb02c93efec01f62f5 Cr-Commit-Position: refs/heads/master@{#317375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M components/domain_reliability/config.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M components/domain_reliability/monitor.h View 2 chunks +6 lines, -5 lines 0 comments Download
M components/domain_reliability/monitor.cc View 4 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
grt (UTC plus 2)
PTAL
5 years, 10 months ago (2015-02-20 16:06:09 UTC) #1
Deprecated (see juliatuttle)
On 2015/02/20 16:06:09, grt wrote: > PTAL lgtm.
5 years, 10 months ago (2015-02-20 19:15:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945923002/1
5 years, 10 months ago (2015-02-20 19:37:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 19:40:28 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 19:41:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2792ed71482cd849ebf312fb02c93efec01f62f5
Cr-Commit-Position: refs/heads/master@{#317375}

Powered by Google App Engine
This is Rietveld 408576698