Ignore setSelectionRange when node is un-parented.

Ignore setSelectionRange when node is un-parented.

BUG=400339
R=eae@chromium.org,leviw@chromium.org
TEST=editing/input/orphan-set-selection-range.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190609

[eae, 2015-02-20 21:35:15]

LGTM

[leviw_travelin_and_unemployed, 2015-02-20 21:53:49]

https://codereview.chromium.org/945873003/diff/20001/Source/core/html/HTMLTex...
File Source/core/html/HTMLTextFormControlElement.cpp (right):

https://codereview.chromium.org/945873003/diff/20001/Source/core/html/HTMLTex...
Source/core/html/HTMLTextFormControlElement.cpp:351: if (hasOpenShadowRoot() ||
!isTextFormControl() || !parentOrShadowHostNode())
You probably want isRooted(). If you parent this form control element into
another element it'd pass this test, but still not be in the document.

[szager1, 2015-02-20 22:04:58]

New patchsets have been uploaded after l-g-t-m from eae@chromium.org

[szager1, 2015-02-20 22:05:18]

https://codereview.chromium.org/945873003/diff/20001/Source/core/html/HTMLTex...
File Source/core/html/HTMLTextFormControlElement.cpp (right):

https://codereview.chromium.org/945873003/diff/20001/Source/core/html/HTMLTex...
Source/core/html/HTMLTextFormControlElement.cpp:351: if (hasOpenShadowRoot() ||
!isTextFormControl() || !parentOrShadowHostNode())
On 2015/02/20 21:53:48, leviw wrote:
> You probably want isRooted(). If you parent this form control element into
> another element it'd pass this test, but still not be in the document.

Done.

[leviw_travelin_and_unemployed, 2015-02-20 22:40:28]

LGTM.

https://codereview.chromium.org/945873003/diff/60001/LayoutTests/NeverFixTests
File LayoutTests/NeverFixTests (right):

https://codereview.chromium.org/945873003/diff/60001/LayoutTests/NeverFixTest...
LayoutTests/NeverFixTests:190: [ Release ]
editing/input/orphan-set-selection-range.html [ WontFix ]
I normally wouldn't bother with this since it'll pass on release anyways.

https://codereview.chromium.org/945873003/diff/60001/LayoutTests/editing/inpu...
File LayoutTests/editing/input/orphan-set-selection-range.html (right):

https://codereview.chromium.org/945873003/diff/60001/LayoutTests/editing/inpu...
LayoutTests/editing/input/orphan-set-selection-range.html:1: <script
src="../../resources/js-test.js"></script>
DOCTYPE html, yo ;)

[szager1, 2015-02-20 23:05:07]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2015-02-20 23:05:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945873003/60001

[commit-bot: I haz the power, 2015-02-21 00:04:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-21 00:04:08]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...)

[szager1, 2015-02-21 00:50:48]

New patchsets have been uploaded after l-g-t-m from leviw@chromium.org

[szager1, 2015-02-21 00:51:01]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2015-02-21 00:51:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/945873003/80001

[commit-bot: I haz the power, 2015-02-21 02:19:35]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190609