Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 945873002: CpuProfiler: move StringsStorage class to separate source and header files. (Closed)

Created:
5 years, 10 months ago by loislo
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CpuProfiler: move StringsStorage class to separate source and header files. Mechanical change. This will break dependency between profiler-generator and heap-profiler-generator. Later this will help us to reuse SourcePosition in cpu-profiler. BUG=452067 LOG=n Committed: https://crrev.com/9b02dc5b5fa65c12ad74e3a660361cb22f180ae5 Cr-Commit-Position: refs/heads/master@{#26780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -145 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap-snapshot-generator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator.h View 1 chunk +1 line, -30 lines 0 comments Download
M src/profile-generator.cc View 1 chunk +0 lines, -114 lines 0 comments Download
A src/strings-storage.h View 1 chunk +47 lines, -0 lines 0 comments Download
A src/strings-storage.cc View 1 chunk +123 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
loislo
5 years, 10 months ago (2015-02-20 13:50:27 UTC) #2
loislo
On 2015/02/20 13:50:27, loislo wrote: PTAL
5 years, 10 months ago (2015-02-20 13:50:48 UTC) #3
yurys
lgtm, I believe we don't need StringStorage for CPU profiler and could eliminate its usages ...
5 years, 10 months ago (2015-02-20 14:07:17 UTC) #4
loislo
On 2015/02/20 14:07:17, yurys wrote: > lgtm, > > I believe we don't need StringStorage ...
5 years, 10 months ago (2015-02-20 14:15:18 UTC) #5
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-20 14:42:59 UTC) #7
Michael Starzinger
LGTM (rubber-stamped).
5 years, 10 months ago (2015-02-20 14:44:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945873002/1
5 years, 10 months ago (2015-02-20 15:09:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 15:15:54 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 15:15:57 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 15:16:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b02dc5b5fa65c12ad74e3a660361cb22f180ae5
Cr-Commit-Position: refs/heads/master@{#26780}

Powered by Google App Engine
This is Rietveld 408576698