Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 945853005: Revert of Carry out a resize even if no layout has been performed. (Closed)

Created:
5 years, 10 months ago by marcheu
Modified:
5 years, 10 months ago
CC:
blink-reviews, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Carry out a resize even if no layout has been performed. (patchset #11 id:200001 of https://codereview.chromium.org/911083002/) Reason for revert: Speculative revert for: https://code.google.com/p/chromium/issues/detail?id=460294 Original issue's description: > Carry out a resize even if no layout has been performed. > > Add a FrameView resize in WebviewImpl::performResize if no layout has been > performed. This to fix the case where a layout is not performed because the > layout height is forced to zero (and therefore no layouts are performed when > the actual height is changed). > > BUG=457159 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190424 TBR=aelias@chromium.org,boliu@chromium.org,hush@chromium.org,gsennton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457159 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -107 lines) Patch
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 3 chunks +26 lines, -37 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 2 chunks +1 line, -44 lines 0 comments Download
D Source/web/tests/data/button.html View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
marcheu
Created Revert of Carry out a resize even if no layout has been performed.
5 years, 10 months ago (2015-02-21 01:49:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945853005/1
5 years, 10 months ago (2015-02-21 01:50:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190607
5 years, 10 months ago (2015-02-21 01:51:19 UTC) #3
Ken Russell (switch to Gerrit)
CC'ing myself in case any issues come up with this revert.
5 years, 10 months ago (2015-02-21 01:55:42 UTC) #5
gsennton
5 years, 10 months ago (2015-02-24 15:24:44 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/949623007/ by gsennton@chromium.org.

The reason for reverting is: Reland as this was not causing the problem..

Powered by Google App Engine
This is Rietveld 408576698