components/cronet/android/java/src/org/chromium/net/HttpUrlRequest.java - Issue 945843003: [Cronet] Do not call into native adapter after it is destroyed in ChromiumUrlRequest.java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/HttpUrlRequest.java

Issue 945843003: [Cronet] Do not call into native adapter after it is destroyed in ChromiumUrlRequest.java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test in the async case Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/MockUrlRequestJobTest.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/MockUrlRequestJobTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/HttpUrlRequest.java

diff --git a/components/cronet/android/java/src/org/chromium/net/HttpUrlRequest.java b/components/cronet/android/java/src/org/chromium/net/HttpUrlRequest.java

index 733847a7073f29adddf5398af8c14125e8fdf779..1a39a4619699f89cc75af0629cbaf90185b99582 100644

--- a/components/cronet/android/java/src/org/chromium/net/HttpUrlRequest.java

+++ b/components/cronet/android/java/src/org/chromium/net/HttpUrlRequest.java

@@ -144,7 +144,8 @@ public interface HttpUrlRequest {

/**

* Returns the HTTP status text of the status line. For example, if the

- * request has a "HTTP/1.1 200 OK" response, this method returns "OK".

+ * request has a "HTTP/1.1 200 OK" response, this method returns "OK". It

+ * returns null if the request has not started.

String getHttpStatusText();